Close

Profile: Jcomp

Avatar

User posts

Bugs
4 years ago

I'm getting errors from Google search console: "Missing field "name", Missing field "price", Either "offers", "review", or "aggregateRating" should be specified

The bug is related to nopcommerce 4.30 (https://github.com/nopSolutions/nopCommerce/issues/4129) microdata was moved to a separate view, and in Emporium Theme there is a duplicate of "itemscope itemtype="http://schema.org/Product"" attributes.
Files: ProductTemplate.Simple.cshtml and ProductTemplate.Grouped.cshtml
Line 65: <div itemscope itemtype="http://schema.org/Product" data-productid="@Model.Id">

Removing it fixes the problem.

4 years ago

Is there any possible way to have custom DataSource for JCaroucel?
I would like to have the possibility to exclude some Categories/Vendors/Products from "Recently Added Products" and it seems it's impossible.

todor.atanasov wrote:
Greetings!

This is the default behaviour for nopCommerce. If you change the Language or Currency, it reloads the page but deletes all the parameters that are in the URL.

Unfortunately, this is something we don't want to modify as it means we would have to change the core of nopCommerce.

Hello Todor,

I can agree that changing Language and Currency is the critical path and can live with such kind of behavior. But what is not acceptable is when user change page size of the grid all filters disappears. And when the user is changing the sorting of the grid it works as expected i.e. filters remain persistent.

Unfortunately, I wasn't able to replicate the issue.

Could you please raise a ticket in which you can provide us with the URL and steps to replicate the issue, so we can investigate further?



No need to create a ticket, I've figured out what was the problem. For some reason "Product Page Size Dropdown Selector" contains wrong selector - "#products-pagesize" instead of "#products-pagesize-mobile, #products-pagesize-desktop". It might be related to the fact I've updated component a month ago. Anyway, the problem is resolved thanks for the help!

todor.atanasov wrote:
Greetings!

This is the default behaviour for nopCommerce. If you change the Language or Currency, it reloads the page but deletes all the parameters that are in the URL.

Unfortunately, this is something we don't want to modify as it means we would have to change the core of nopCommerce.


Hello Todor,

I can agree that changing Language and Currency is the critical path and can live with such kind of behavior. But what is not acceptable is when user change page size of the grid all filters disappears. And when the user is changing the sorting of the grid it works as expected i.e. filters remain persistent.

If I have some filters applied and then change Language/Currency/Page the filters are reset.

Steps:
1. Go to http://demos.nop-templates.com/computers#/specFilters=2m!#-!6 Filter by "CPU Type" and selected "Intel Core i5" is applied.
2. Change active currency/language

Actual result: All products within category computers are shown (URL changed to http://demos.nop-templates.com/computers without filter parameters)
Expected result: Filter remains persistent when changing language/currency/page size, just like it behaves when you change sorting

Hello,

I've downloaded and installed NopEmporiumTheme_4.2.370.30389 and bug is still there :-(

Hello Anton,

Please check http://gamma.monety.com.ua/ now.

As you can see the Nop Sale of the Day is loaded but pictures are not displayed. Try to scroll page and you will that images are shown.

My view on the problem is: sevenSpikesCore.loadImagesOnScroll() is called before owl.carousel is initialized.

Well, thanks. But that is not what I'm trying to achieve. I'm just trying to say that lazy loading images suppose to work and there is a bug in Nop Sale of the Day component which needs to be fixed.

As workaround following could be used:


(function ($) {
    $(document).ready(function () {
        var owl = $('.owl-carousel');
        if (owl.length > 0) {
            // Listen to owl event initialized:
            owl.on('initialized.owl.carousel', function (event) {
                // Hook loadImagesOnScroll to lazy load image in owl carousel
                window.sevenSpikesCore.loadImagesOnScroll();
            });
        }
    });
})(jQuery);


Is there any better solution?

Hi,

I'm trying to get Sale of the Day working and got a problem that pictures are not displayed until user scroll the page;

I think because of lazy loading picture and for some reason, it is not considered as the picture in the current viewport.

Demo: http://gamma.monety.com.ua