Close
Avatar

User posts

10 years ago

Our customer is trying to add a Google remarking script to their site via the HTML Widgets plugin. We tell them they can add scripts via the HTML Widget -> Tools -> Source Code <> option.  They are using the body_end_html_tag_before zone.  

This is the script Google gave them (google_conversion_id changed) ... Note the /* commented */ CDATA lines in the original:

<!-- Google Code for Remarketing Tag -->
<script type="text/javascript">
/* <![CDATA[ */
var google_conversion_id = 9999999999;
var google_custom_params = window.google_tag_params;
var google_remarketing_only = true;
/* ]]> */
</script>
<script type="text/javascript" src="//www.googleadservices.com/pagead/conversion.js">
</script>
<noscript>
<div style="display:inline;">
<img height="1" width="1" style="border-style:none;" alt="" src="//googleads.g.doubleclick.net/pagead/viewthroughconversion/9999999999/?value=0&amp;guid=ON&amp;script=0"/>
</div>
</noscript>


After saving, the /* commented */ portions get parsed (which breaks the script):

<!-- Google Code for Remarketing Tag -->
<p>
<script>// <![CDATA[
var google_conversion_id = 9999999999;
var google_custom_params = window.google_tag_params;
var google_remarketing_only = true;
// ]]></script>
<script src="//www.googleadservices.com/pagead/conversion.js">// <![CDATA[

// ]]></script>
</p>
<noscript>
<div style="display:inline;">
<img height="1" width="1" style="border-style:none;" alt="" src="//googleads.g.doubleclick.net/pagead/viewthroughconversion/9999999999/?value=0&amp;guid=ON&amp;script=0"/>
</div>
</noscript>


See the following support URL from Google on the topic:

https://support.google.com/tagassistant/answer/2978937?ref_topic=2947092#cdata_comments

Id really like to avoid having to add this to any CSHTML files since a) this puts scripting back in our court as opposed to letting our customers maintain this info themselves, and b) this complicates upgrades.

FWIW we are seeing similar issues on other 3rd-party scripts as well.  Any thoughts on how to handle this?

Bugs
10 years ago

Here's another really small one.  I turned on "Private Messages" today and the "unread messages" text is wrapping:

https://drive.google.com/file/d/0BxSwbWwuTCU1cEdMbktmcVNzeGM/edit?usp=sharing

10 years ago

Exactly what I expected to hear, but never hurts to ask!  :)

BTW - Its not a big deal and it was easily rectified, but I would consider the JCarousel Title issue to be a bug.  Since there is a flag on the JCarousel settings for the user to select whether the Title is shown, I would expect this theme to respect that flag automatically without having to alter the CSS.

Regardless, thatnks for teh great support.

Bob

10 years ago

Worked Perfectly.  Thanks!

Now Ill push my luck a bit (I think I know the answer but Id be remiss not to ask).  Is there any way without completely overhauling the theme to add these items as tabs?  In other words, Id love to be able to add Best Sellers, New Products, Featured Products, etc all on my homepage, but it makes things a bit too busy (especially if you automate the JCarousels).  In a perfect world I could do something like this.

Thoughts?

Bugs
10 years ago

Looks like there is a small bug with the Smart theme in Chrome.  When resizing the browser window, the search input in the header never properly realigns if you expand the window again.  All other browsers I tested worked as expected.

Here's a video from your live demo:

http://screencast.com/t/BCttIWs702uY

10 years ago

Is there a way to display the "Featured Products" and "Featured Categories" titles on the homepage within this theme?  Is this omitted on purpose or is it a bug?  All of your other themes display these titles.

On that same note, when adding a JCarousel to the homepage, even when the "Show Title" check box is checked the title is not being displayed.  This makes the Carousel mostly useless because users wont know what they are looking at.

I'm on nopCommerce v3.2 and using Smart Theme build 3.2.839 if that's relevant

Thanks!

10 years ago

Oakstone wrote:
On the category admin page, there is an option 'include in top menu'. Can this be used to limit what displays in the Mega Menu? For example, I only want to display 3 of the 4 parent categories I have.

Thanks.


Just FYI - I just logged into the forum to make this exact same request!

10 years ago

Im just playing around with the HTML Plugins module for the first time and had a quick question.  Is there any reason that the Plugin only has 24 Widget Zones enabled by default?  I un-commented out all of the other zones within SupportedWidgetZones.xml and they all seem to work.

Is there any negative impact on leaving everything un-commented so that my (admin) users can add html wherever they want?  It seems much more functional now but I figure it must be this way for a reason (reliability, performance, etc.)?

Thanks.

10 years ago

Is there a setting or some css that I can add that will disable the vertical "float" on the menu when the user scrolls up / down the page.  I find that the menu takes up too much space on smaller mobile devices and also flickers a bit upon scrolling so Id like to lock that in its default location.

Thanks!

Bugs
10 years ago

Not offended at all.  I welcome the conversation.  I also don't want to come off as the "PRO IE8" guy.  Totally not my stance or point.  That all being said, its my opinion as a developer that we either have to support an environment or not.  That's why I asked that question in the original post.  If we portend to support IE8 then we cant say "... as long as you use it like I want you to."  My nop site isnt live yet and I have bigger fish to fry at the moment, but I don't feel its even usable via IE8.  Worse yet is that its not *my* site, but my customers.  Im trying to get in front of having to explain to them (non-developers) why the website that they are paying top dollar for doesn't work from their office computer.

Regarding nop-templates limited resources, if this is something that will take weeks to resolve than I agree with your sentiment, but if they can spend a few days on it and its fixed forever that seems a worthwhile endeavor.  After all, these aren't my numbers based on limited sample size.  Even if they are trending downward, the stats in my link are current and global.