Profile: jakubz

Hi! maybe you help me with this log:

  

 at Microsoft.AspNetCore.Server.Kestrel.Core.BadHttpRequestException.Throw(RequestRejectionReason reason)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1MessageBody.PumpAsync()
   at System.IO.Pipelines.PipeCompletion.ThrowLatchedException()
   at System.IO.Pipelines.Pipe.GetReadResult(ReadResult& result)
   at System.IO.Pipelines.Pipe.GetReadAsyncResult()
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.MessageBody.ReadAsync(Memory`1 buffer, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpRequestStream.ReadAsyncInternal(Memory`1 buffer, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.WebUtilities.FileBufferingReadStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.WebUtilities.StreamHelperExtensions.DrainAsync(Stream stream, ArrayPool`1 bytePool, Nullable`1 limit, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Mvc.Formatters.JsonInputFormatter.ReadRequestBodyAsync(InputFormatterContext context, Encoding encoding)
   at Microsoft.AspNetCore.Mvc.ModelBinding.Binders.BodyModelBinder.BindModelAsync(ModelBindingContext bindingContext)
   at Microsoft.AspNetCore.Mvc.ModelBinding.ParameterBinder.BindModelAsync(ActionContext actionContext, IModelBinder modelBinder, IValueProvider valueProvider, ParameterDescriptor parameter, ModelMetadata metadata, Object value)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerBinderDelegateProvider.<>c__DisplayClass0_0.<<CreateBinderDelegate>g__Bind|0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeInnerFilterAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextResourceFilter()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeFilterPipelineAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeAsync()
   at Microsoft.AspNetCore.Builder.RouterMiddleware.Invoke(HttpContext httpContext)
   at StackExchange.Profiling.MiniProfilerMiddleware.Invoke(HttpContext context) in C:\***dotnet\src\MiniProfiler.AspNetCore\MiniProfilerMiddleware.cs:line 94
   at Nop.Services.Authentication.AuthenticationMiddleware.Invoke(HttpContext context) in C:\xxxx\nop-4.10\src\Libraries\Nop.Services\Authentication\AuthenticationMiddleware.cs:line 79
   at Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
   at Nop.Core.Http.InstallUrlMiddleware.Invoke(HttpContext context, IWebHelper webHelper) in C:\xxxx\nop-4.10\src\Libraries\Nop.Core\Http\InstallUrlMiddleware.cs:line 51
   at Nop.Core.Http.KeepAliveMiddleware.Invoke(HttpContext context, IWebHelper webHelper) in C:\xxxxx\nop-4.10\src\Libraries\Nop.Core\Http\KeepAliveMiddleware.cs:line 50
   at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware.Invoke(HttpContext context)

Hi! guys, i looks today our logs, and found something like below:

System.InvalidOperationException: A second operation started on this context before a previous operation completed. Any instance members are not guaranteed to be thread safe.
   at Microsoft.EntityFrameworkCore.Internal.ConcurrencyDetector.EnterCriticalSection()
   at Microsoft.EntityFrameworkCore.Query.Internal.LinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.MoveNext()
   at System.Collections.Generic.List`1.AddEnumerable(IEnumerable`1 enumerable)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Nop.Core.Caching.MemoryCacheManager.Get[T](String key, Func`1 acquire, Nullable`1 cacheTime) in C:\*******\nop-4.10\src\Libraries\Nop.Core\Caching\MemoryCacheManager.cs:line 152
   at Nop.Services.Catalog.ReviewTypeService.GetAllReviewTypes() in C:\****\nop-4.10\src\Libraries\Nop.Services\Catalog\ReviewTypeService.cs:line 50
   at Nop.Web.Factories.ProductModelFactory.PrepareProductReviewsModel(ProductReviewsModel model, Product product) in *******\Presentation\Nop.Web\Factories\ProductModelFactory.cs:line 1402
   at SevenSpikes.Nop.Plugins.NopQuickTabs.Controllers.ProductTabsComponent.GetProductReviewsModel(Product product)
   at SevenSpikes.Nop.Plugins.NopQuickTabs.Controllers.ProductTabsComponent.PopulateMainTabs(TabUIModel model, Product product)

Hi! hmm… we just update nop 4.0 > 4.1 today our nop used 81% of CPU... after disable Ribbons it's use 10-20-30%...

Is any knowed issue in this plugin?

We have 7 ribbons / 48 products on page…

1. Promotion - showing -20% if discount is …
2. Out of stock
3. Newproduct
4. "First in country" - here we set ovveride on product..
5. Free delivery - if bigger than 100 $
6. Free delivery - if bigger than 150 $
7. "ribbon category" - when product is in category X
Our shop have maybe 100 categories about 1600 products?

I tested it now, and when i  ribbons, and start watching website (only category). In few minutes CPU grow to 80%.

Strange situation. Open category when i'm logged on admin... increase cpu 20-30%... when i do a same like a guest it's +10%?


After disable ribbons… cpu is 5-10% with higher score 40-50%... ?

We use element earth theme variant 1

1. Maybe you want add possibility give "checkbox" subscribe me to newsletter in ROPC?

Now we have only Accept Terms of service... we can add there order attributes, but it's not "supported" by nopcommerce newsletter subscribers.

It's should be great, add there checkbox with "consent for subscribe me to newsletter" with email from used form in ropc (we have name / email...).

What you think? ;)

Hi!
maybe it's possible to fix / add features supported scenario below.

Actual we use token: old-price-new-price-difference-percentage

1. But... If we add discount on category and "new price" is again reduced 10-20%... token still show percentage only from price before discount. Without summary both reduction old / new price + discount by product / category

2. We add some discount by category, and again then this token not working / we can't add similar. Maybe it's possible to support this scenario?

Hi! i check changelog and don't see change from GDPR law. In my plugin also i don't have checkbox to this... so... i ask:

I want send emails to Client who abandon cart... to do this, i need have permision from client to send newsletters/promo... but nowhere in Nop Customer Reminders i don't have checkbox with information "Send only to active newsletter subscribers" without this i broke a law? so? is it possible to set this in this way?

Hi! ok, thx!

Hi! i think we found a reason slow loading(third part widget).

We still work with performance and i have question:

Is it possible to add lazy loading pictures to your theme?
https://developers.google.com/speed/pagespeed/insights/?hl=pl&url=http%3A%2F%2Fthemes.earth1.element.nop-templates.com%2F

In our case this can give us possibility to increase speed about 1,8 s in category pages.

Hi!
we are looking a reason, why our page works slow. One proposition we received is to turn off all plugins, and try open nopcommerce default theme, and see how then all work.

I'm wonder if we chane our theme to nopcommerce default, we lose informations from Element responsive theme? Element using different size images etc. and i'm little afraid when we swap theme to another, it's can broke something?